[Webkit-unassigned] [Bug 25769] Fix accessibility warnings on GTK

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25769


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30350|review?                     |review+
               Flag|                            |




------- Comment #8 from darin at apple.com  2009-05-16 20:35 PDT -------
(From update of attachment 30350)
>  {
>      struct RoleEntry {
> +    public:
>          String ariaRole;
>          AccessibilityRole webcoreRole;
>      };

This change does not make sense. In a struct, everything is public by default
and this should have no effect. I have no idea why gcc is warning about this,
but I do not think this is the fix.

> Index: WebCore/page/AccessibilityTable.cpp
> ===================================================================
> --- WebCore/page/AccessibilityTable.cpp	(revision 43716)
> +++ WebCore/page/AccessibilityTable.cpp	(working copy)
> @@ -350,7 +350,7 @@ void AccessibilityTable::cells(Accessibi
>      }
>  }
>      
> -const unsigned AccessibilityTable::columnCount()
> +unsigned AccessibilityTable::columnCount()
>  {
>      if (!hasChildren())
>          addChildren();
> @@ -358,7 +358,7 @@ const unsigned AccessibilityTable::colum
>      return m_columns.size();    
>  }
>      
> -const unsigned AccessibilityTable::rowCount()
> +unsigned AccessibilityTable::rowCount()
>  {
>      if (!hasChildren())
>          addChildren();
> Index: WebCore/page/AccessibilityTable.h
> ===================================================================
> --- WebCore/page/AccessibilityTable.h	(revision 43716)
> +++ WebCore/page/AccessibilityTable.h	(working copy)
> @@ -63,8 +63,8 @@ public:
>      AccessibilityChildrenVector& columns();
>      AccessibilityChildrenVector& rows();
>      
> -    const unsigned columnCount();
> -    const unsigned rowCount();
> +    unsigned columnCount();
> +    unsigned rowCount();
>      
>      virtual String title() const;

These changes are good.

I'm saying r=me, but don't land that "public:" change -- it should have no
effect.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.