[Webkit-unassigned] [Bug 19357] [GTK] Loading of resource images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19357





------- Comment #14 from gns at gnome.org  2009-05-15 15:01 PDT -------
(From update of attachment 30181)
> +        Install the four resources we are using. For the icons
> +        were an icon name is specified by freedeskop.org try to

were -> where

> +template <> void freeOwnedGPtr<GtkIconInfo>(GtkIconInfo*);
> +template <> void freeOwnedGPtr<GtkIconInfo>(GtkIconInfo* info)

Why do you need both? Any C++ craziness I'm not aware of?

> +{
> +    if (info)
> +	gtk_icon_info_free(info);
> +}

Indentation is off here, tab? There are many more throughout the patch, it
seems.

> +    GOwnPtr<GtkIconInfo> info(gtk_icon_theme_lookup_icon(gtk_icon_theme_get_default(),
> +							 name, 16, GTK_ICON_LOOKUP_NO_SVG));

There's a comment by kalikiana regarding this already, from the earlier
patches. Why NO_SVG? There are themes which use only SVG files, and there's no
reason not to suport them, I guess. If we are worried about SVG being compiled
out, we could just add a preprocessor guard?

> +    if (!info)
> +	return String::format("%s/webkit-1.0/images/%s.png", DATA_DIR, fallback).utf8();
> +
> +    return CString(gtk_icon_info_get_filename(info.get()));
> +}

More indentation issues.

I would say r=me if those issues (indentation and no SVG) are fixed, or if
there's a rationale for not being able to support SVG in this specific
instance.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.