[Webkit-unassigned] [Bug 25696] gtk directfb screen corruption on scrolling of webview

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25696





------- Comment #4 from hyatt at apple.com  2009-05-15 10:36 PDT -------
Also, please don't mark bugs as reviewed if you are not a reviewer.  I'll give
you the benefit of the doubt and assume you meant to set it to ? instead.

Anyway this patch is no good, since it just turns off blitting on scrolling
completely.  This isn't something you should have to do.  All you're doing is
working around bugs in your port's blitting implementation by doing this when
you should be fixing those bugs.

The code that clips is also unnecessary.  As I said on webkit-dev, it is the
responsibility of WebKit to clip to the document dirty rect before you even get
into ScrollView paint.  Because you can have nested ScrollViews, repeatedly
clipping to the document dirty rect is not something that these ScrollViews
should need to do.  

Clipping to the visibleContentRect is necessary for each subframe ScrollView
because the dirty rect may partially overlap the frame, but clipping to the
document dirty rect should not be needed, as it should only happen once.  It is
the WebView's responsibility to do this clipping in your WebKit port.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.