[Webkit-unassigned] [Bug 25822] DOM normalize does not remove empty text node between element nodes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25822


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30390|review?                     |review+
               Flag|                            |




------- Comment #3 from darin at apple.com  2009-05-15 10:26 PDT -------
(From update of attachment 30390)
> -    for (; node; node = node->traverseNextNodePostOrder()) {
> +    for (; node; ) {

Should be changed a while, then.

> +        } else {
> +            node = node->traverseNextNodePostOrder();

WebKit style doesn't use braces around single lines. Typically we'd use "early
continue" in a case like this:

    if (type != TEXT_NODE) {
        node = node->traverseNextNodePostOrder();
        continue;
    }

I'd really like to see a more thorough set of test cases. Adding a test for
only the single case that shows the current bug seems too minimal.

r=me as is -- none of my requested changes are mandatory


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.