[Webkit-unassigned] [Bug 25068] Complex text support for Chromium Linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25068


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29298|review?(fishd at chromium.org) |review-
               Flag|                            |




------- Comment #3 from eric at webkit.org  2009-05-14 22:14 PDT -------
(From update of attachment 29298)
Bah,  I hit submit early.

All the places you use "harfbuzz" probably should hav ea differnet name.  We
don't care that we're using "harfbuzz" more that we're iterating over the text
runs or?

What is iter doing here?
 393         ssize_t iter = 0;
 394         while (iter < run.length()) {

Seems that too needs a better name.

r- for all the nits above.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.