[Webkit-unassigned] [Bug 25807] #ifdef properly the WebCore/platform/gtk/KeyboardCodes.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25807


zecke at selfish.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30357|review?                     |review-
               Flag|                            |




------- Comment #2 from zecke at selfish.org  2009-05-14 20:24 PDT -------
(From update of attachment 30357)
No, that is way too ugly this way. Please let us go back to the problem and
then talk about solutions.

So your problem is:
   - Some VK_ are already there

My questions:
   - Why do you have a define for WIN_CE? There is no Gtk+ port to Windows CE?!

Proposed change:
   - Make the change with one #if !PLATFORM(GTK) block instead of squattering
that ugly thing all around. Alternatively create a cleaned
KeyboardCodesGtkWin32.h and include that from KeyEventGtk.cpp


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.