[Webkit-unassigned] [Bug 25808] Create file uri from filename properly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25808


gns at gnome.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30358|review?                     |review-
               Flag|                            |




------- Comment #2 from gns at gnome.org  2009-05-14 14:50 PDT -------
(From update of attachment 30358)
> +#ifndef _WIN32
>      // we avoid the escaping for local files, because
>      // g_filename_from_uri (used internally by GFile) has problems
>      // decoding strings with arbitrary percent signs
>      if (url.isLocalFile())
>          d->m_gfile = g_file_new_for_path(url.prettyURL().utf8().data() + sizeof("file://") - 1);
>      else
> +#endif

I think you want to use #if !PLATFORM(WIN_OS) here?

Looks fine otherwise. Also, add a ChangeLog entry, please.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.