[Webkit-unassigned] [Bug 25779] Allow Strings to be created with one malloc node with no copying

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25779


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30351|review?                     |review+
               Flag|                            |




------- Comment #4 from darin at apple.com  2009-05-14 14:00 PDT -------
(From update of attachment 30351)
> +        * platform/text/PlatformString.h:
> +        * platform/text/String.cpp:
> +        * platform/text/StringImpl.cpp:
> +        * platform/text/StringImpl.h
> +:

The lists of affected functions are missing. The colon on this last line is on
a separate line.

> +    // Returns an uninitialized string. The characters needs to be written
> +    // into the buffer returned in data before using
> +    static String createUninitialized(unsigned length, UChar*& data);

The comment seems to stop mid-sentence. Or maybe it's just a missing period.

> +String String::createUninitialized(unsigned length, UChar*& data)
> +{
> +    return StringImpl::createUninitialized(length, data);
> +}

This should be inlined. No reason to pay function call overhead here.

r=me as is, but maybe fix those things above and post a new patch?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.