[Webkit-unassigned] [Bug 25774] Need to upstream V8MessagePortCustom.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 14 07:45:18 PDT 2009


eric at webkit.org changed:

           What    |Removed                     |Added
  Attachment #30307|review?                     |review-
               Flag|                            |

------- Comment #2 from eric at webkit.org  2009-05-14 07:45 PDT -------
(From update of attachment 30307)
It seems we could share some code between the onMessage and onClose handlers
no?  I think I would have used a static function to make those long if/else
blocks not need to be copy/paste there.  Please feel free to re-mark r=? if I'm
missing something.

Otherwise the code looks sane enough.  createHiddenDependency and
removeHiddenDependency seem confusing... what are they for?

I assume also that this is already covered by existing layout tests?  Otherwise
this needs some form of testing.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list