[Webkit-unassigned] [Bug 25760] Font leak in Chromium's Skia backend.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 13 16:25:01 PDT 2009


------- Comment #8 from eric at webkit.org  2009-05-13 16:25 PDT -------
(From update of attachment 30294)
WebKit style guidelines:
"Use full words, except in the rare case where an abbreviation would be more
canonical and easier to understand."

I would re-write this block:
+            FontPlatformData* fpd =
AtomicString(reinterpret_cast<char*>(family)), false);
+            ret = getCachedFontData(fpd);


AtomicString fontFamily(reinterpret_cast<char*>(family));
ret = getCachedFontData(getCachedFontPlatformData(font.fontDescription(),
fontFamily), false)

or as platformData =

Otherwise looks fine.  I can fix it an land for you.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list