[Webkit-unassigned] [Bug 25755] Implement ARIA grid role

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25755





------- Comment #7 from bdakin at apple.com  2009-05-13 14:51 PDT -------
Okay, that breakdown is really helpful, thanks Chris. Based on the breakdown,
it looks like there is only one spot where we are currently at risk of
crashing, so it is good that you will be patching it.

But for the sake of readable code and a coherent class, I think some of the
other spots should be patched as well. The places that check that you are a
table or return early if you are an aria table are all fine too. But when you
see code that automatically casts a renderer to a RenderTable it could make you
believe that any AccessibilityTable's renderer is a RenderTable, which we know
is not true now that we have grids implemented. As you said, we won't crash in
these spots because all of these functions are overridden in the various Grid
classes, but for coherency I think you should patch them with early returns
anyway. Does that make sense?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.