[Webkit-unassigned] [Bug 25419] InspectorController refactoring proposal

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25419


pfeldman at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30240|0                           |1
        is obsolete|                            |




------- Comment #15 from pfeldman at chromium.org  2009-05-13 06:42 PDT -------
Created an attachment (id=30273)
 --> (https://bugs.webkit.org/attachment.cgi?id=30273&action=view)
step_2_patch

>> Also JsonObject should be named JSONObject per our style guidelines.
>> ("Capitalize the first letter, including all letters in an acronym, 
>> in a class, struct, protocol, or namespace name.")

Done.

>> 80     addDOMStorage.appendArgument(jsonObject.scriptObject());
>> I assume that scriptObject returns a string with the serialized JSON.
>> If so maybe including "serialized" in the function would make things clear.

Not yet - it is returning underlying script object so far. It will have
'stringify' and 'parse' later.

>> Wont this require changes on the ForntEnd side too?

Again, not yet.

Sorry about missing JSON* files - fell off my git cycle.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.