[Webkit-unassigned] [Bug 25742] Fix RenderThemeChromiumWin::paintTextFieldInternal() not to hide background image.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 12 19:14:50 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=25742


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30258|review?(brettw at chromium.org)|review-
               Flag|                            |




------- Comment #2 from eric at webkit.org  2009-05-12 19:14 PDT -------
(From update of attachment 30258)
Brett Wilson is not a webkit reviewer.  You also do not need to mark the
requestee field for WebKit reviews.

I would have written this line:

Color backgroundColor = o->style()->backgroundColor().isValid() ?
o->style()->backgroundColor() : Color::white;

Does this match other platforms' behaviors here?

This needs test cases.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list