[Webkit-unassigned] [Bug 25649] [webkit-gtk] Wrong handling of file upload if no file selected
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 12 11:00:44 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=25649
------- Comment #5 from mrowe at apple.com 2009-05-12 11:00 PDT -------
You should set the review flag to ? to get a patch reviewed. I see a few
issues with the patch that should be addressed:
1) It would be clearer to be structured to have an early-return
2) It uses tabs for indentation instead of spaces
3) A return statements has redundant parentheses.
4) There should be a space after "if" and before the parenthesis.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list