[Webkit-unassigned] [Bug 25325] Make sure pthread_self() is declared before it gets called
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 11 20:46:52 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=25325
------- Comment #3 from laszlo.1.gombos at nokia.com 2009-05-11 20:46 PDT -------
(In reply to comment #2)
> (From update of attachment 29680 [review])
> >
> > #if PLATFORM(SOLARIS)
> > #include <thread.h>
> > -#endif
> > -
> > -#if PLATFORM(OPENBSD)
> > +#else
> > #include <pthread.h>
> > #endif
> >
> I'm not convinced why including this for WINDOWS and DARWIN is a good idea.
This entire code segment is guarded with
#if PLATFORM(DARWIN)
#elif PLATFORM(WIN_OS)
#elif PLATFORM(UNIX)
so pthread.h won't be included for WIN_OS and DARWIN.
I realize that the diff does not show enough context in this case. With this
additional information, I will put up the patch for review again.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list