[Webkit-unassigned] [Bug 25701] REGRESSION(r38788 & r42020): styled searchfields look wrong on Windows, affects Facebook

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 11 13:21:04 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=25701





------- Comment #4 from alice.liu at apple.com  2009-05-11 13:21 PDT -------
=\  I forgot to explain the padding thing fully. 

http://trac.webkit.org/changeset/42020

this change removed the code path that adjusted the appearance of searchfield
after all the style was already applied.  We used to call
RenderThemeWin::adjustSearchFieldStyle, and now we just specify the padding
rules in themeWin.css, but the problem was that the padding rules needed to be
applied last in order to look exactly the way it used to.  

Do we no longer care that much to preserve this padding we had in Safari 3?  If
not, i can take it out.  I think as long as we just make the change to not
respect background image styling on searchfields, then the facebook searchfield
will look okay on Windows.  


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list