[Webkit-unassigned] [Bug 25419] InspectorController refactoring proposal

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25419


timothy at hatcher.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30186|review?                     |review-
               Flag|                            |




------- Comment #11 from timothy at hatcher.name  2009-05-11 10:07 PDT -------
(From update of attachment 30186)
I like this patch and it is a nice and mechanical change. I have a few comments
and nitpicks, but over all nothing major.

There are a couple of tab characters sprinkled in this patch. Please remove
them, otherwise it will fail to commit.

> +    , m_bound(false)

I prefer the m_scriptObjectCreated variable name you used for InspectorResource
over m_bound.

> +    initBody: function(args)

I think setMessageBody would be a better name.

r- for the tabs. But please consider the other comments.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.