[Webkit-unassigned] [Bug 14845] Frame's noResize attribute can not be set by JavaScript

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=14845


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27859|review?                     |review-
               Flag|                            |




------- Comment #15 from eric at webkit.org  2009-05-11 05:52 PDT -------
(From update of attachment 27859)
 130         if (attached() && parentNode()->renderer()->isFrameSet()) {
 131             HTMLFrameSetElement* fs =
static_cast<HTMLFrameSetElement*>(parentNode());

seems like an unsafe check.  Just because the renderer() is a frameset, doesn't
necessarily mean the Element is.  I think you should check hasTagName instead.

I've never seen this convention before:
m_noResize = !attr->isNull();

I didn't realize that parseMappedAttribute was called when an attribute was
removed?

I also don't see how attr->isNull() will return true when noResize="false"?

The test case would be better if it printed PASS or FAIL instead of just
printing the resulting metrics.

r- for the attr->isNull() issue.  I'm confused as to if that code actually
works.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.