[Webkit-unassigned] [Bug 25654] Does not compile on X86_64

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25654


ggaren at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30146|review?                     |review-
               Flag|                            |




------- Comment #2 from ggaren at apple.com  2009-05-08 16:28 PDT -------
(From update of attachment 30146)
> From ad2cb622ba352ba693352072e5b6e64abfed2576 Mon Sep 17 00:00:00 2001
> From: Sebastian Andrzej Siewior <sebastian at breakpoint.cc>
> Date: Sat, 9 May 2009 00:31:08 +0200
> Subject: [PATCH 2/2] JavaScriptCore: fix complie on x86_64 boxes
> 
> The assembly code is for 32bit cpus and breaks compilation on 64bit cpus.
> PLATFORM(MAC) is defined in case PLATFORM(DARWIN) is defined which in turn
> is defined if __APPLE__ is defined. This is the case on PowerPC machines. The
> "new" iMacs should have __x86_64__ defined and be handled by PLATFORM(X86_64)
> 
> Signed-off-by: Sebastian Andrzej Siewior <sebastian at breakpoint.cc>
> ---
>  JavaScriptCore/jit/JITArithmetic.cpp |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/JavaScriptCore/jit/JITArithmetic.cpp b/JavaScriptCore/jit/JITArithmetic.cpp
> index 9f325e3..3a776cc 100644
> --- a/JavaScriptCore/jit/JITArithmetic.cpp
> +++ b/JavaScriptCore/jit/JITArithmetic.cpp
> @@ -44,11 +44,11 @@
>  
>  using namespace std;
>  
> -#if PLATFORM(MAC)
> -
> +#if PLATFORM(X86_64)
> +/* Shortcut: All x86-64 CPUs support SSE2 so we can skip this  */
>  static inline bool isSSE2Present()
>  {
> -    return true; // All X86 Macs are guaranteed to support at least SSE2
> +    return true;
>  }

I think this will disable sse2 optimizations on 32bit x86. I think you want "if
PLATFORM(X86_64) || (PLATFORM(X86) && PLATFORM(MAC))".


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.