[Webkit-unassigned] [Bug 25613] [GTK] Allow to embed any GtkWidget for embed/object

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 8 04:56:39 PDT 2009


------- Comment #6 from zecke at selfish.org  2009-05-08 04:56 PDT -------

> I'm going to be a pain in the ass and say that this should go in a separate
> commit :D

no problem. the addition doesn't stand by itself though, without the rest of
the patch no one is using this template specialization, without a
user/benefitor the change doesn't make sense... at least this was my logic.

> The rest of the patch looks good to me, but since it's new API I'll wait for
> Gustavo's review to give r+ (we have a rule now to require two reviews for new
> API).

Take your time, I have not put much thinking into it but from using it for a
bit... what if you don't want a certain plugin to load but don't want to
provide a GtkWidget? create-plugin will not allow you to do this... maybe you
want to have another signal, a different API.... or such.. :)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list