[Webkit-unassigned] [Bug 25613] [GTK] Allow to embed any GtkWidget for embed/object

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25613





------- Comment #4 from xan.lopez at gmail.com  2009-05-07 23:59 PDT -------
(From update of attachment 30097)
> +template <> void freeOwnedGPtr<GHashTable>(GHashTable* ptr)
> +{
> +    if (ptr)
> +        g_hash_table_unref(ptr);
> +}
> +
>  } // namespace WTF
> diff --git a/JavaScriptCore/wtf/GOwnPtr.h b/JavaScriptCore/wtf/GOwnPtr.h
> index bbb793a..8d03ff2 100644
> --- a/JavaScriptCore/wtf/GOwnPtr.h
> +++ b/JavaScriptCore/wtf/GOwnPtr.h
> @@ -35,6 +35,7 @@ namespace WTF {
>      template<> void freeOwnedGPtr<GMutex>(GMutex*);
>      template<> void freeOwnedGPtr<GPatternSpec>(GPatternSpec*);
>      template<> void freeOwnedGPtr<GDir>(GDir*);
> +    template<> void freeOwnedGPtr<GHashTable>(GHashTable*);
>  
>      template <typename T> class GOwnPtr : Noncopyable {
>      public:

I'm going to be a pain in the ass and say that this should go in a separate
commit :D

The rest of the patch looks good to me, but since it's new API I'll wait for
Gustavo's review to give r+ (we have a rule now to require two reviews for new
API).


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.