[Webkit-unassigned] [Bug 24992] crash at http://browserspy.dk/browser.php

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 7 23:23:10 PDT 2009


ap at webkit.org changed:

           What    |Removed                     |Added
  Attachment #30111|review?                     |review+
               Flag|                            |

------- Comment #15 from ap at webkit.org  2009-05-07 23:23 PDT -------
(From update of attachment 30111)
> +        Not sure how I would create a test case for this patch, sorry!
> +
> +        * loader/FrameLoader.cpp:
> +        (WebCore::FrameLoader::didOpenURL):

There should be a bug URL and title in the ChangeLog, so that one could easily
find the associated discussion. Also, it's best to describe changes for each
function - that's why the list of functions is generated.

As mentioned in a previous comment, we should have an ASSERT in
Frame::setJSStatusBarText(), so that accidental undoing of this fix (or other
similar issues) would be caught regardless of platform used. In fact, it would
be useful to add such assertions before other client calls.

r=me - I'll address my nitpicks while landing.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list