[Webkit-unassigned] [Bug 25436] Refactor appCache for use in multi-process browsers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25436





------- Comment #11 from michaeln at google.com  2009-05-07 13:28 PDT -------
 > A reviewer (myself or someone else) will need to understand a plan for how
the
> new interfaces will fit in existing code and logic, both in multi-process and
> single-process cases.

Lets start with just the 'frontend' pieces. The interfaces in the 'frontend'
subdirectory (of the patch attached here) are used by Frame, HTMLHtmlElement,
and DOMApplicationCache.

* Frame owns a WebApplicationCacheContext instance. (unlike the existing code)

* DOMApplicationCache gets a reference to WebApplicationCache via
Frame.appcachecontext(), script invoked method  calls result in the
corresponding call to WebApplicationCache methods. (similar to the existing
code)

* DOMApplicationCache ISA WebApplicationCacheDelegate, delegate method
overrides surface the corresponding event to script. (decoupled from the
backend, unlike the existing code)

* HTMLHtmlElement invokes selectAppCacheWithManifest (similar to the existing
appcache code)

Concrete impls of the WebApplicationCacheContext and WebApplicationCache
classes serve as proxies to communicate with the 'backend'. They contain very
little logic. In a single-process browser, the proxy boils down to thread
messaging. In a multi-process browser, the proxy employs IPC. The settable
factory method for WebApplicationCacheContext creates the appropiate impl for
the hosting browser.

Anything there unclear?


Also, a potential reviewer has some extra credit work that could be done as
well.
* Read thru this, http://docs.google.com/Doc?id=dvvc3n9_0dkfddscs
* Look at the patch "outline of some interfaces" patch attached to this issue
* Look at this chromium patch, http://codereview.chromium.org/79036
* Ask questions to clarify


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.