[Webkit-unassigned] [Bug 25575] Registered mutation event listener crashes HTMLMediaElement

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 6 20:49:26 PDT 2009


darin at apple.com changed:

           What    |Removed                     |Added
                 CC|                            |darin at apple.com

------- Comment #4 from darin at apple.com  2009-05-06 20:49 PDT -------
(In reply to comment #2)
> Firing a mutation event for something in the shadow tree seems wrong.

There are three separate ways to fix this I can think of:

1) Fix it so mutation events don't fire for elements in shadow trees. This is a
problem regardless. If JavaScript code in the main page can get a pointer to a
node in the shadow tree, we've got trouble.

2) Setting the initial value of the precision attribute needn't be done inside
the constructor and probably shouldn't. It can just be done by
RenderMedia::createTimeline instead. Generally we should do as little as
possible in derived classes and just use HTML classes in any case we can.
Moving the setAttribute call is probably the quickest fix to the problem.

3) To set initial attributes in a way more like the way the parser does, you
could create a NamedNodeMap and call setAttributeMap instead. I am pretty sure
this code path won't fire any DOM mutation events.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list