[Webkit-unassigned] [Bug 25385] Upstream changes to V8 bindings for supporting nested workers.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25385


dglazkov at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29777|review?                     |review-
               Flag|                            |




------- Comment #2 from dglazkov at chromium.org  2009-05-05 15:56 PDT -------
(From update of attachment 29777)
Style looks good! :)

> +        if (result.IsEmpty()) {
> +            v8::Local<v8::Object> object = toV8(type, type, impl);
> +            if (!object.IsEmpty())
> +                static_cast<Worker*>(impl)->ref();
> +            result = v8::Persistent<v8::Object>::New(object);
> +            V8Proxy::SetJSWrapperForDOMObject(impl, result);
> +        }
> +        return result;

Would it be a bit more clear to inverse this:

if (!result.IsEmpty())
   return result;
...

> +    return PassRefPtr<EventListener>();

Can just return 0;


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.