[Webkit-unassigned] [Bug 25513] V8 CSSStyleDeclaration bindings are slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25513


dglazkov at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29949|review?(dglazkov at chromium.or|review-
               Flag|g)                          |




------- Comment #2 from dglazkov at chromium.org  2009-05-05 11:22 PDT -------
(From update of attachment 29949)
Just a few nits/comments:

> +class CSSPropertyInfo {
> +  public:

align public to class.

> +    static HashMap<String, CSSPropertyInfo*> map;

Use DEFINE_STATIC_LOCAL macro.

> +        if (!length)
> +            return NULL;

return 0.

> +        else if (WTF::isASCIIUpper(propertyName[0]))
> +            return NULL;

return 0.

> -    INC_STATS("DOM.CSSStyleDeclaration.NamedPropertyGetter");
> +    //INC_STATS("DOM.CSSStyleDeclaration.NamedPropertyGetter");

Did you mean leave this in?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.