[Webkit-unassigned] [Bug 25562] Potential crash after ApplicationCacheStorage::storeNewestCache() fails.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25562


ap at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30017|review?                     |review-
               Flag|                            |




------- Comment #2 from ap at webkit.org  2009-05-05 05:30 PDT -------
(From update of attachment 30017)
+        Check return value of ApplicationCacheStorage::storeNewestCache()
+        at its call site in ApplicationCacheGroup::checkIfLoadIsComplete().
+        https://bugs.webkit.org/show_bug.cgi?id=25562
+
+        * loader/appcache/ApplicationCacheGroup.cpp:
+        (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):

I'd structure the ChangeLog differently:

        https://bugs.webkit.org/show_bug.cgi?id=25562
        Potential crash after ApplicationCacheStorage::storeNewestCache() fails

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
        Check return value of ApplicationCacheStorage::storeNewestCache(), and
<...>
        if it failed.

+            // We failed to store the new cache. Report an error.
+            postListenerTask(&DOMApplicationCache::callErrorListener,
m_associatedDocumentLoaders);

Is this sufficient? I would expect cache failure steps to be run
<http://www.whatwg.org/specs/web-apps/current-work/#cache-failure-steps>, just
like in case when subresource loading fails. With this code, we just get a
non-stored newest cache, which will likely cause problems later on.

r-, because I think that cache failure steps need to be run here.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.