[Webkit-unassigned] [Bug 25558] New: Rendering fix for <select> elements.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25558

           Summary: Rendering fix for <select> elements.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: agl at chromium.org


Rendering fix for <select> elements.

When switching a <select> element from display:none to default
display, we would fail to invalidate the parent's pref widths in some
situations:

When attaching the element, RenderMenuList::updateOptionsWidth would
call setNeedsLayoutAndPrefWidthsRecalc before the parent pointer was
set. This would mark the pref widths as dirty, but not for any parent
objects.

When RenderObjectChildList::appendChildNode later calls
setNeedsLayoutAndPrefWidthsRecalc again, with a valid parent pointer,
nothing would be done because the pref widths were already dirty for
the RenderMenuList.

Without this patch, the <select> element will spill outside of the
table in the layout test.

This issue was often hidden because, depending on whitespace,
the presence of <option> elements etc, there would often be an empty
RenderText node after the <select> element. This could do the job of
invalidating the parent's pref widths. It's only when this element
isn't present that the bug bites.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.