[Webkit-unassigned] [Bug 25503] Add instrumentation framework to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25503





------- Comment #3 from simon.fraser at apple.com  2009-05-04 17:10 PDT -------
Some general feedback (I didn't read Sam's yet)

* I'm not sure I like the pairing of a specific start signal
("recalcStyleStarting") with a generic end signal ("finished"). Seems like it
would be good to force pairing, even if just to assert that they are correctly
paired.
* Rather than hard-coding all the categories in method names, why not make it
extensible:

analysisClient()->start("parsing");
analysisClient()->end("parsing");

Then you just need a hash to store data in on the collection side.

* Why have WebAnalysisClient in WebKit? Seems like the mechanics of data
collection and analysis will be the same for every platform, so should be in
WebCore. Then what you export via WebKit is:
i) a way to turn it on and off
ii) a way to get at the raw data (e.g. for a UI visualizer) or summary data?
I think WebCore should also have code to dump the output. You could use a log
channel for output, maybe.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.