[Webkit-unassigned] [Bug 25544] toString (function source) for event listeners in V8 bindings shows wrapper code

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 4 05:35:56 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=25544


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29988|                            |review-
               Flag|                            |




------- Comment #2 from eric at webkit.org  2009-05-04 05:35 PDT -------
(From update of attachment 29988)
In general if you need a review, you need to mark things with r=? otherwise
they won't appear in the queue.

There are several typos in the changelog.

This needs a test added to LayoutTests (probably in LayoutTests/fast/js)

String::append is generally a slow way to build strings, StringBuilder or
Vector<UChar> is faster.  But in this case it may not matter.

r- for lack of test.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list