[Webkit-unassigned] [Bug 24883] Bad success test in parseXMLDocumentFragment in XMLTokenizerLibxml2.cpp
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 4 01:46:28 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=24883
------- Comment #3 from eric at webkit.org 2009-05-04 01:46 PDT -------
(From update of attachment 29010)
Actually, I should be more clear:
This patch is fantastic. You clearly read and understood the instructions on
how to submit a patch! I look forward to reviewing more patches from you
soon!
A few nits:
1. You are missing EMAIL_ADDRESS on your LayoutTest Changelog
2. We probably don't want these:
Added: svn:eol-style
+ native
if anything we want LF (unix style)
3. The test would be slightly better if it just output PASS or FAIL instead of
the actual dumped chars:
+This test checks to see if setting innerHTML to a single non-breaking space
works.
+Original: Â
+Result: Â
Otherwise, again, this is a fantastic patch. Very easy to review!
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list