[Webkit-unassigned] [Bug 25332] Bare .swf files loaded via plug-in fail to load

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25332


mrowe at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




------- Comment #6 from mrowe at apple.com  2009-05-03 23:22 PDT -------
I spent a little while debugging this tonight.  What's happening is that when
creating the Flash plug-in, WebFrameLoaderClient::createPlugin is being called
with loadManually=true, indicating that the main resource stream should be used
for the data.  However, this stream was already used for the WebKit plug-in
that was initially created.  Since loadManually is not false we won't
explicitly request the plug-in source URL, resulting in the Flash plug-in never
receiving any data.  The code in FrameLoader::loadPlugin currently always sets
loadManually=true for plug-ins in a plug-in document, working on the assumption
that there will only ever be a single plug-in in the document.  ClickToFlash's
behavior clearly violates this assumption.  We can fix this by having
FrameLoader::loadPlugin only pass loadManually=true if the plug-in will receive
data from the main resource.  I can't see a direct way of determining that, but
we can approximate this by checking if this is the first plug-in to be inserted
in to the plug-in document (isPluginDocument() && !m_containsPlugIns).  In my
tests, this fixes the bug.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.