[Webkit-unassigned] [Bug 25496] Switch V8EventListenerList to a hashtable implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25496


dglazkov at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29950|review?                     |review+
               Flag|                            |




------- Comment #5 from dglazkov at chromium.org  2009-05-01 18:46 PDT -------
(From update of attachment 29950)
You did good! Just a few comments below.

> +        No new functionality so no new tests.
> +
> +        * bindings/v8/V8EventListenerList.cpp:
> +        (WebCore::V8EventListenerListIterator::V8EventListenerListIterator):
> +        (WebCore::V8EventListenerListIterator::~V8EventListenerListIterator):
> +        (WebCore::V8EventListenerListIterator::operator++):
> +        (WebCore::V8EventListenerListIterator::operator==):
> +        (WebCore::V8EventListenerListIterator::operator!=):
> +        (WebCore::V8EventListenerListIterator::operator*):
> +        (WebCore::V8EventListenerListIterator::seekToEnd):
> +        (WebCore::V8EventListenerList::V8EventListenerList):
> +        (WebCore::V8EventListenerList::~V8EventListenerList):
> +        (WebCore::V8EventListenerList::begin):
> +        (WebCore::V8EventListenerList::end):
> +        (WebCore::getKey):
> +        (WebCore::V8EventListenerList::add):
> +        (WebCore::V8EventListenerList::remove):
> +        (WebCore::V8EventListenerList::clear):
> +        (WebCore::V8EventListenerList::find):

No need to leave all these hanging. Can just say:

 +        * bindings/v8/V8EventListenerList.cpp: Added
V8EventListenerListIterator.

> +int getKey(v8::Local<v8::Object> object)

static int getKey(...


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.