[Webkit-unassigned] [Bug 21794] Middle-click panning should be springloaded while dragging

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21794


jhoneycutt at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30713|review?                     |review+
               Flag|                            |




------- Comment #22 from jhoneycutt at apple.com  2009-05-27 13:49 PDT -------
(From update of attachment 30713)
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 44197)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,23 @@
> +2009-05-27  Itai Danan  <idanan at chromium.org>
> +
> +        Reviewed by jhoneycutt at apple.com.

We usually use the reviewer's name; I'm Jon Honeycutt.

> +
> +        As per Bug 21794 (https://bugs.webkit.org/show_bug.cgi?id=21794),
> +	added an option for springloaded panscroll instead of sticky
> +	scroll. To understand why this is required see the discussion in
> +	issue 24722 (https://bugs.webkit.org/show_bug.cgi?id=24722).
> +
> +        * page/EventHandler.cpp:
> +        (WebCore::EventHandler::handleMousePressEvent): Use autoscroll behavior flag to determine
> +	if autoscroll needs to be released on this event.
> +        (WebCore::EventHandler::handleMouseReleaseEvent):  Use autoscroll behavior flag to determine
> +	if autoscroll needs to be released on this event (reverse logic of for Press event).

I think you added some tabs here. WebKit uses 4 spaces for indentation.

r=me if you fix the tabs. Thanks for the patch, Itai!


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.