[Webkit-unassigned] [Bug 24070] Changing "scrolling" attribute on iframe element already in DOM doesn't take effect
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 31 18:42:48 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=24070
cwzwarich at uwaterloo.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28060|review? |review-
Flag| |
------- Comment #5 from cwzwarich at uwaterloo.ca 2009-03-31 18:42 PDT -------
(From update of attachment 28060)
+ if (attached()) {
Is there any need to check attached() here? Shouldn't checking contentFrame()
be enough?
+ if (contentFrame() && contentFrame()->view()) {
+ FrameView* view = contentFrame()->view();
+ view->changeScrollbarsState(m_scrolling !=
ScrollbarAlwaysOff);
+ }
+ }
There is already a method on FrameView for setting the scrollbar state:
void setCanHaveScrollbars(bool canScroll);
You should use that instead of making your own. I'm r-'ing this patch, but I am
glad that you are fixing this bug.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list