[Webkit-unassigned] [Bug 24965] HTMLMediaElement: network state changes can be missed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 31 15:10:34 PDT 2009


simon.fraser at apple.com changed:

           What    |Removed                     |Added
  Attachment #29132|review?                     |review+
               Flag|                            |

------- Comment #2 from simon.fraser at apple.com  2009-03-31 15:10 PDT -------
(From update of attachment 29132)
> +            MediaPlayer::ReadyState currentState = m_player->readyState();
> +            if (static_cast<ReadyState>(currentState) != m_readyState)

This cast is pretty heinous. It would be nice to:
1. Have MediaPlayer ReadyState have a somewhat different name
2. Have a method that converts them: ReadyState
readyStateForPlayerReadyState(PlayerReadyState) rather than casting.

But those can be done in a later commit.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list