[Webkit-unassigned] [Bug 24908] run-webkit-tests unable to set timeout manually

Tue Mar 31 09:51:15 PDT 2009

https://bugs.webkit.org/show_bug.cgi?id=24908

aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29107|review?                     |review-
               Flag|                            |

------- Comment #5 from aroben at apple.com  2009-03-31 09:51 PDT -------
(From update of attachment 29107)
> +  --timeout                       Sets the length of time before a test times out

The Usage output should indicate that --timeout takes a parameter. It would be
good for it to also say what the default value is.

> +    'timeout-seconds=i' => \$timeoutSeconds,

This wasn't changed to match the new name of the option.

Your ChangeLog should also mention that this patch changes the default value
back to 60 seconds from 15. Or your patch keep the default at 15 seconds (which
might be better).

r- since the code doesn't match the Usage statement.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.