[Webkit-unassigned] [Bug 24851] Failures in http/tests/xhlhttprequest/web-apps on Windows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 31 08:54:12 PDT 2009


------- Comment #15 from bweinstein at gmail.com  2009-03-31 08:54 PDT -------
(In reply to comment #14)
> (From update of attachment 29105 [review])
> The comparisons to -1 still look unnecessary to me.

I feel like they are necessary in this case, because in the first comparison,
if there is no space in the original response text, a comparison to -1 there is
much cheaper than doing another whole find call. For the second comparison, I
was considering the pathological case where there is one space in the text
(like "HTTP/1.1 OK"), where the first find would return 8, but then calling
find(' ', 9), would return -1, and if we used that -1 result, the status text
after removing the status code would be "HTTP/1.1 OK" instead of what I felt
was the expected "OK".

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list