[Webkit-unassigned] [Bug 24938] --no-svg has build problems

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 30 10:29:03 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=24938





------- Comment #2 from simon.fraser at apple.com  2009-03-30 10:29 PDT -------
(From update of attachment 29075)
=>          case CSSPropertyWebkitTextStroke:
>          case CSSPropertyWebkitTransition:
>          case CSSPropertyWebkitVariableDeclarationBlock:
> +        case CSSPropertyWebkitPerspectiveOriginX:
> +        case CSSPropertyWebkitPerspectiveOriginY:
> +        case CSSPropertyWebkitTransformOriginX:
> +        case CSSPropertyWebkitTransformOriginY:
> +        case CSSPropertyWebkitTransformOriginZ:

I think these were left out on purpose. We don't want authors to get style for
'transform-origin-x' etc, just the compound property 'transform-origin'.

> Index: WebCore/css/CSSParser.cpp
> ===================================================================
> --- WebCore/css/CSSParser.cpp	(revision 42106)
> +++ WebCore/css/CSSParser.cpp	(working copy)
> @@ -1625,6 +1625,7 @@ bool CSSParser::parseValue(int propId, b
>      case CSSPropertyTextLineThrough:
>      case CSSPropertyTextOverline:
>      case CSSPropertyTextUnderline:
> +    case CSSPropertyWebkitVariableDeclarationBlock:
>          return false;

I don't see enough context to know if this is correct. I belive CSS variables
are disabled now anyway.

> Index: WebCore/css/CSSStyleSelector.cpp
> ===================================================================
> --- WebCore/css/CSSStyleSelector.cpp	(revision 42106)
> +++ WebCore/css/CSSStyleSelector.cpp	(working copy)
> @@ -5185,6 +5185,7 @@ void CSSStyleSelector::applyProperty(int
>      case CSSPropertyWebkitPaddingStart:
>      case CSSPropertyWebkitTextDecorationsInEffect:
>      case CSSPropertyWebkitTextStroke:
> +    case CSSPropertyWebkitVariableDeclarationBlock:

Ditto.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list