[Webkit-unassigned] [Bug 24656] cacheControlContainsNoCache() in ResourceResponseBase.h is wrong
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Mar 29 12:12:05 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=24656
ddkilzer at webkit.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
------- Comment #11 from ddkilzer at webkit.org 2009-03-29 12:12 PDT -------
(In reply to comment #10)
> (In reply to comment #9)
> > Dave, please check how the current code handles e.g. "Cache-Control:
> > private=must-revalidate" - instead of treating must-revalidate as a header
> > name, it sets m_cacheControlContainsMustRevalidate to true.
>
> Yep, I agree that this broke in r39383.
This is still the incorrect fix:
- directiveValues.append(directives[i].second);
+ directiveValues.append(directives[i].first);
Basically, the for() loop in
ResourceResponseBase::parseCacheControlDirectives() that was added in r39383
needs to be fixed so it's checking for the must-revalidate keyword instead of a
sub-value of a "private" or "no-cache" directive.
I'll try to fix this soon-ish.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list