[Webkit-unassigned] [Bug 24904] Add a defaultMimeType to ResourceRequest

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 28 09:57:45 PDT 2009


------- Comment #5 from abarth at webkit.org  2009-03-28 09:57 PDT -------
(In reply to comment #4)
> My understanding is that one cannot reliably add data members to
> ResourceRequest - they are converted to platform requests and  back, so any
> members that cannot be stored inside a platform request will be lost after a
> delegate call.

Are platform requests in webkit.org source repository somewhere?  I'd like to
understand this better.

> Now, this specific use is only necessary on Chromium, which may not use
> willSendRequest-style delegate calls, but the member is added to
> ResourceRequestBase, which one would expect to work reliably on all platforms.

We can move the member to Chromium's ResourceRequest.  I have another patch in
progress that adds some data for mixed content detection, but for that patch
the reviewer asked to move the member to ResourceRequestBase because it would
be useful to other ports.

In this case, any port that uses the HTML 5 content sniffing algorithm will
need this member to render sites correctly.

> Also, "defaultMimeType" should be "defaultMIMEType" per our coding style guide.

I'll fix this in the next patch update.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list