[Webkit-unassigned] [Bug 24884] New: Include strings.h for strcasecmp()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 27 06:56:33 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=24884

           Summary: Include strings.h for strcasecmp()
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: laszlo.1.gombos at nokia.com


IEEE Std 1003.1-2001 placed strcasecmp() in strings.h. 

Most (but not all) platforms also declare strcasecmp in string.h, so the lack
of the strings.h include usually does not get noticed.

The compile time problem I run into is
http://trac.webkit.org/browser/trunk/WebCore/loader/TextResourceDecoder.cpp
calls strcasecmp() but strings.h is not included.

A similar case has been reported an solved in
http://trac.webkit.org/changeset/38176/trunk/JavaScriptCore/runtime/DateMath.cpp. 

There are at least two options to consider - (a) continue including strings.h
in each cpp where strcasecmp() is called or (b) include strings.h in
StringExtras.h where strcasecmp() is implemented for Win.

I feel that (b) might be a more future-proof (since Win ports are well
maintained).

Patch follows.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list