[Webkit-unassigned] [Bug 24767] reduce number of calls to String::append in V8LazyEventListener

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24767


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28873|review?(dglazkov at chromium.or|review-
               Flag|g)                          |




------- Comment #3 from eric at webkit.org  2009-03-26 11:41 PDT -------
(From update of attachment 28873)
Is this the proper multi-line string syntax?   i.e. why were there \ before but
not now?

We have a String::printf I think, wouldn't that be more efficient than this 3
appends?  You might actually want to use StringBuilder here instead, or just a
Vector<UChar>

Also, this should be "const char*" in WebKit style.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.