[Webkit-unassigned] [Bug 24636] Fix crash of Chromium port in use of BackForwardList in SVG images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24636


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28755|review?                     |review-
               Flag|                            |




------- Comment #8 from eric at webkit.org  2009-03-26 11:32 PDT -------
(From update of attachment 28755)
I would have just added an ASSERT(m_client) before these calls in all cases:

-    return m_client->backListCount();
+    if (m_client)
+        return m_client->backListCount();
+    ASSERT_NOT_REACHED();
+    return 0;

No need to work hard to crash only in debug mode.

The changelog should mention the bug url.

Also is there no way to test this?  There should be a layout test if at all
possible.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.