[Webkit-unassigned] [Bug 24776] Disabling HTML5 Database breaks the build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24776





------- Comment #8 from sam at webkit.org  2009-03-25 13:11 PDT -------
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 28891 [review] [review])
> > Why not just put an #ifdef around Database.cpp so it doesn't compile?
> > 
> > > +    void Document::setHasOpenDatabases();
> > > +    bool Document::hasOpenDatabases();
> > 
> > Also, this will break some builds, r-.
> > 
> 
> Hi Sam,
> 
> Database.cpp is needed in the build for DatabaseAuthorizer.cpp, which is used 
> in the SQLite code for other features like the Icon Database so I don't think
> just #ifdef'ing out the file will work. 

This is the issue then.  We need to detangle DatabaseAutorizer from SQLite
code, indeed, that is a layering violation.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.