[Webkit-unassigned] [Bug 24693] Disable all the SVG features for WebKit/Qt if ENABLE_SVG=0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 25 12:05:03 PDT 2009


------- Comment #3 from laszlo.1.gombos at nokia.com  2009-03-25 12:05 PDT -------
(In reply to comment #2)
> (From update of attachment 28744 [review])
> Looks sensible and will work with the below macros. Another way would be to put
> the ENABLE_SVG_* macros into a block...
> e.g. contains(DEFINES, ENABLE_SVG=1) {
>    !contains(FOO): DEFINES += ENABLE_FOO=1
> }
> but I would have to check the qmake manual... it would be nice if you could do
> a follow up.

Thanks for the review !

It seems to me that one of the goals of the build system is to make sure that
all the ENABLE_FOO flags are defined (either to 0 or 1) instead of leaving them
undefined (as an example ENABLE_WML is set to 0 if it is not defined

The patch originally proposed maintains this goal, but the suggestion above
does not maintain this goal and will leave ENABLE_FOO undefined if ENABLE_SVG
is set to 0. 

This might be a matter of taste, but I think that the original patch is more
consistent with the existing code.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list