[Webkit-unassigned] [Bug 24684] Clean up WebCore based on Coverty Prevent static analysis results

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24684


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28903|review?                     |review+
               Flag|                            |




------- Comment #18 from darin at apple.com  2009-03-24 14:20 PDT -------
(From update of attachment 28903)
> +        Fix case where lBreak.obj->isBR() when lBreak.obj was NULL
> +	https://bugs.webkit.org/show_bug.cgi?id=24684
> +
> +	I don't have a test case where we were taking the wrong path here
> +	However, adding an ASSERT(lBreak.obj) before this usage caused
> +	multiple bidi tests to fail, so lBreak.obj can be null here.

Tabs in ChangeLog.

> -    if (lBreak == resolver.position() && !lBreak.obj->isBR()) {
> +    if (lBreak == resolver.position() && (!lBreak.obj || !lBreak.obj->isBR())) {

Seems harmless to add this, even though it may be impossible in practice.

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.