[Webkit-unassigned] [Bug 24776] Disabling HTML5 Database breaks the build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24776





------- Comment #3 from benm at google.com  2009-03-24 11:21 PDT -------
(In reply to comment #2)
> (From update of attachment 28891 [review])
> Why not just put an #ifdef around Database.cpp so it doesn't compile?
> 
> > +    void Document::setHasOpenDatabases();
> > +    bool Document::hasOpenDatabases();
> 
> Also, this will break some builds, r-.
> 

Hi Sam,

Database.cpp is needed in the build for DatabaseAuthorizer.cpp, which is used 
in the SQLite code for other features like the Icon Database so I don't think
just #ifdef'ing out the file will work. I guess the other alternative is to
#ifdef out the parts of Database.cpp that call into the Document but changing
the ifdef's in Document.cpp|h and the InspectorController seemed like the
clearer and simpler solution to me.

I can fix the syntax in Document.h and upload a new patch if you think this is
worth pursuing. Please let me know your thoughts.

Thanks, Ben


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.