[Webkit-unassigned] [Bug 24685] Use Skia integer primitives for drawing Chromium Linux scrollbars

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 23 11:40:22 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=24685


darin at chromium.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28737|review?(darin at chromium.org) |review-
               Flag|                            |




------- Comment #2 from darin at chromium.org  2009-03-23 11:40 PDT -------
(From update of attachment 28737)
> +static void drawVertLine(SkCanvas* canvas, int x, int y1, int y2, const SkPaint& paint) {
> +  SkIRect skrect;
> +  skrect.set(x, y1, x + 1, y2 + 1);
> +  canvas->drawIRect(skrect, paint);
> +}

nit: please use webkit style (4 space indent, bracket on newline).  there are a
lot of
these style violations in this patch as well as in the previous file.  please
fix :)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list