[Webkit-unassigned] [Bug 24760] Clean up Position.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 23 09:55:01 PDT 2009


darin at apple.com changed:

           What    |Removed                     |Added
  Attachment #28855|review?                     |review+
               Flag|                            |

------- Comment #3 from darin at apple.com  2009-03-23 09:55 PDT -------
(From update of attachment 28855)
> +
> +    // Returns node() or the closest element accestor
> +    Element* element() const;
>      Element* documentElement() const;

The paragraphing here makes it look like this comment is for both element() and
documentElement(). The comment also seems to be unclear about what this will
return when node() is not an element, but there is no closest element ancestor.
The answer is "0", but the comment makes it sound like we'd return node(),
which isn't possible since it's not an Element*.

Why are you removing clear()? I like clear(), and all the functions where
you’re removing it seem, well, less clear after the change. What does removing
it have to do with the other changes you’re planning?

r=me, but really?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list